fix(keybinds): Prevent crash on keypress before settingClass is initialized

cwcinc commented

2026-10-10 22:50:49 +02:00

Contributor

Mod keybind listeners are added to window as soon as registerKeybind is called, but settingClass is only set when PolyTrack first builds its settings. A keypress in between throws TypeError: Cannot read properties of undefined (reading 'checkKeyBinding') and brings up the error screen.

This bug can be reproduced in the current version by pressing keys as the game loads. Any keyboard event can trigger this error.

This fix changes this.settingClass.checkKeyBinding(...) to this.settingClass?.checkKeyBinding(...). Until settingClass exists, the condition is falsy (undefined), so the keypress is ignored and the callback doesn't run. Once the game builds its settings, keybinds work as before.

Mod keybind listeners are added to window as soon as registerKeybind is called, but settingClass is only set when PolyTrack first builds its settings. A keypress in between throws TypeError: Cannot read properties of undefined (reading 'checkKeyBinding') and brings up the error screen. This bug can be reproduced in the current version by pressing keys as the game loads. Any keyboard event can trigger this error. This fix changes this.settingClass.checkKeyBinding(...) to this.settingClass?.checkKeyBinding(...). Until settingClass exists, the condition is falsy (undefined), so the keypress is ignored and the callback doesn't run. Once the game builds its settings, keybinds work as before.

Screenshot 2026-10-10 115614.png

45 KiB